Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpython: use correct variable to set meta.mainProgram #247955

Merged
merged 1 commit into from
Aug 8, 2023
Merged

cpython: use correct variable to set meta.mainProgram #247955

merged 1 commit into from
Aug 8, 2023

Conversation

SuperSandro2000
Copy link
Member

Description of changes

#246386

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@SuperSandro2000 SuperSandro2000 mentioned this pull request Aug 8, 2023
Merged
12 tasks
@AndersonTorres AndersonTorres merged commit 4514e57 into NixOS:master Aug 8, 2023
6 checks passed
@FRidh
Copy link
Member

FRidh commented Aug 9, 2023

Were there any cases where python3 was not correct? I don't think so.

@SuperSandro2000 SuperSandro2000 deleted the python-mainprogram branch August 9, 2023 09:35
@SuperSandro2000
Copy link
Member Author

true but if we have the variable we might as well use it to not have any edge cases in the future where that might not be correct.

@PedroRegisPOAR
Copy link
Contributor

Were there any cases where python3 was not correct? I don't think so.

Yes.

The python3Minimal one.

nix run github:NixOS/nixpkgs/nixpkgs-unstable#python3Minimal -- --version

Outputs:

Python 3.10.12

While with older nixpkgs version (before this merge):

nix run github:NixOS/nixpkgs/release-23.05#python3Minimal -- --version

Outputs:

error: unable to execute '/nix/store/rs24a32xmzdwd6frh42m4vac0vpg8rpj-python3-minimal-3.10.13/bin/python3-minimal': No such file or directory

@PedroRegisPOAR PedroRegisPOAR mentioned this pull request Dec 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol drupol approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SuperSandro2000 @FRidh @PedroRegisPOAR @drupol @AndersonTorres